search

dotnet / windows-sdk-for-google-analytics

SDK to connect to Google Analytics from Windows Store (UWP) Apps, Windows desktop apps written with .NET, and Xamarin Apps
MIT License
102 stars 33 forks source link

issue 7. C# tracker was crashing when platformInfoProvider == null, t… #8

Closed jaimerodriguez closed 7 years ago

jaimerodriguez commented 7 years ago

Tim: Note that this allows C# tracker to take a null platformInfoProvider. I feel this is valid on desktop, so i added a null check in tracker to pass tests. lmk if you disagree...

dnfclas commented 7 years ago

Hi @jaimerodriguez, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

dnfclas commented 7 years ago

@jaimerodriguez, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;