Refactor classes with multiple private boolean fields to use flags enum

[elachlan]

I performed a search for "private bool _" and filtered out classes with 4 or less fields, the collated and ordered results are in the table below.

I believe we can convert these to use BitVector32 to save runtime memory usage.

• [ ] System\Windows\Forms\Controls\ComboBox\ComboBox.cs - 16
• [ ] System\Windows\Forms\Layout\Containers\SplitContainer.cs - 13
• [ ] System\Windows\Forms\Controls\ListBoxes\ListBox.cs - 12
• [x] System\Windows\Forms\DataBinding\BindingSource.cs - 12
• [ ] System\Windows\Forms\ToolTip\ToolTip.cs - 9
• [ ] System\Windows\Forms\Controls\PropertyGrid\PropertyGrid.cs - 6
• [ ] System\Windows\Forms\Controls\ToolStrips\ToolStripManager.ModalMenuFilter.cs - 6
• [x] System\Windows\Forms\DataBinding\Binding.cs - 6
• [ ] System\Windows\Forms\Dialogs\TaskDialog\TaskDialog.cs - 6
• [ ] System\Windows\Forms\Controls\MonthCalendar\MonthCalendar.cs - 5
• [x] System\Windows\Forms\DataBinding\CurrencyManager.cs - 5
• [x] System\Windows\Forms\ErrorProvider\ErrorProvider.cs - 5
• [ ] System\Windows\Forms\Printing\PrintPreviewControl.cs - 5

[elachlan]

@JeremyKuhne before I go crazy with this, does the team prefer:

• const int masks, manually defined
• private static readonly int masks via BitVector32.CreateMask
• or private static readonly BitVector32.Section via BitVector32.CreateSection?

Also, I was thinking of changing the private fields to properties to reduce the surface area of the refactor. That way we only touch the fields.

[JeremyKuhne]

Bools only take a byte per so there really is no point for doing anything for 4 or less.

Really we should just use a [Flags] enum for cases where we have several bools in a class. It is much easier to manage and probably results in the smallest code.

EnumExtensions.ChangeFlags<T> is the helper I wrote to efficiently change flags. The idea was to get rid of all of our other Get/Set flag helpers. It should probably move to Core.

[elachlan]

I'll go through and do all the classes with 5 or more properties. I'll switch the fields to properties to hide the logic and reduce the surface area of the change. I'll also move the extension method so it is in core.

[JeremyKuhne]

@elachlan so each class would have something like {ClassName}Flags nested at an appropriate underlying type size (byte, short, int, long).

[elachlan]

@JeremyKuhne yes. I'll also put the enum in a separate file.

[elachlan]

@JeremyKuhne can we use a byte based flags enum for 2-8 bools? That way we cover the 2-4 bool field cases as well.

[JeremyKuhne]

@elachlan I wouldn't bother as the extra type info and complexity are probably eating any benefit.

[elachlan]

It looks like in other places we have gone with {ClassName}States, so I will go with that naming convention?