search

dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.38k stars 971 forks source link

[main] Update dependencies from dotnet/runtime #11400

Closed dotnet-maestro[bot] closed 4 months ago

dotnet-maestro[bot] commented 4 months ago

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Tanya-Solyanik commented 4 months ago

Test input: typeof(IList<ICustomTypeDescriptor>), Array.Empty<string>()

 Message: 
Assert.Equal() Failure: Collections differ
Expected: string[]                                           []
Actual:   IteratorSelectIterator<PropertyDescriptor, string> ["RequireRegisteredTypes"]
                                                              ↑ (pos 0)

at System.Windows.Forms.Tests.ListBindingHelperTests.ListBindingHelper_GetListItemProperties_InvokeObject_ReturnsExpected(Object list, String[] expected) in D:\a_work\1\s\src\System.Windows.Forms\tests\UnitTests\System\Windows\Forms\ListBindingHelperTests.cs:line 292 at InvokeStub_ListBindingHelperTests.ListBindingHelper_GetListItemProperties_InvokeObject_ReturnsExpected(Object, Span`1) at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Tanya-Solyanik commented 4 months ago

@LakshanF @steveharter - this test is failing because the ICustomTpeDescriptor interface had been updated with a new property - RequireRegisteredTypes. Does this have to be a Browsable property? https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.browsableattribute?view=net-8.0

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.26495%. Comparing base (dff9619) to head (616be6c). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11400 +/- ## =================================================== + Coverage 74.26463% 74.26495% +0.00032% =================================================== Files 3025 3025 Lines 626861 626861 Branches 46742 46742 =================================================== + Hits 465536 465538 +2 + Misses 157980 157970 -10 - Partials 3345 3353 +8 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/11400/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/11400/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `74.26495% <100.00000%> (+0.00032%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/11400/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `17.99135% <ø> (-0.00704%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/11400/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `46.99116% <ø> (+0.00070%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/11400/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `96.98684% <100.00000%> (ø)` | | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/11400/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `43.97109% <ø> (+0.00139%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.