Closed elachlan closed 1 month ago
@Olina-Zhang can your team please test this fix?
Attention: Patch coverage is 83.33333%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 74.29002%. Comparing base (
0aa3a4d
) to head (d2a1031
). Report is 20 commits behind head on main.
@Olina-Zhang can your team please test this fix?
Tested this PR based on the latest .NET 9.0 SDK build for GH Issue: https://github.com/dotnet/winforms/issues/11417, it is fixed with no new issue found.
Thank you @Olina-Zhang!!
Looks like we have a test that checks what we set the tooltip for UpDownBase if what is expected. https://github.com/dotnet/winforms/blob/f53f153808bbbaddda3f0c1e994e8a3b5cc085a9/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/UpDownBaseTests.cs#L3015-L3035
We can use this as a base to write another test checking if setting to empty works as expected. Could you test if setting the tooltip for UpDownBase multiple times works as expected as well?
Thanks I'll write one up and test asap.
@lonitra I added the code to the existing test, since we would have to have the whole test replicated again anyway to set the initial tooltip text.
Makes sure that the
_upDownEdit
and_upDownButtons
have their tooltip removed.Fixes #11417
I am unsure how to add tests for this. I manually tested the fix.