dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.38k stars 971 forks source link

Tests should use theory data #11441

Closed LeafShi1 closed 4 months ago

LeafShi1 commented 4 months ago

Makes progress to fix #11041 Deal with the feedback of the PR #11171

Proposed changes

Customer Impact

Regression?

Risk

-There should be no risk in moving to strongly typed parameterized test methods.

Test methodology

Test environment(s)

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.33994%. Comparing base (d9e9d93) to head (51edb65). Report is 165 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11441 +/- ## =================================================== + Coverage 73.44664% 74.33994% +0.89329% =================================================== Files 3098 3028 -70 Lines 632225 627403 -4822 Branches 46653 46770 +117 =================================================== + Hits 464348 466411 +2063 + Misses 164485 157642 -6843 + Partials 3392 3350 -42 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/11441/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/11441/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `74.33994% <100.00000%> (+0.89329%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/11441/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `17.97822% <ø> (-0.38372%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/11441/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `47.11818% <ø> (+0.20665%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/11441/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `96.98449% <100.00000%> (+1.99849%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/11441/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `44.10422% <ø> (+0.22661%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.