search

dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.28k stars 955 forks source link

Enable `png` based `ico` files and streams to be loaded into `Bitmap` #11469

Open elachlan opened 1 month ago

elachlan commented 1 month ago

In PR #11375 we discovered that when converting bmp based ico resources to be png based, there was a failure when loading the icons as the ToolboxBitmapAttribute tries to create the resource as a bitmap. This errors out as bitmap uses different PInvokes from Icon, with Icon PInvokes supporting png for a few windows versions.

This would enable us to convert the ico files to be png based, saving a few megabytes in an AOT compiled app (#11370).

merriemcgaw commented 3 weeks ago

In all likelihood we won't be able to address this in 9, so moving it to 10