search

dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.38k stars 971 forks source link

Enable nullability in ImageListImage #11472

Closed gpetrou closed 4 months ago

gpetrou commented 4 months ago

Proposed changes

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.36713%. Comparing base (c3832b3) to head (bbd197b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11472 +/- ## =================================================== - Coverage 74.36760% 74.36713% -0.00047% =================================================== Files 3028 3028 Lines 627534 627534 Branches 46764 46764 =================================================== - Hits 466682 466679 -3 - Misses 157499 157509 +10 + Partials 3353 3346 -7 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/11472/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/11472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `74.36713% <0.00000%> (-0.00047%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/11472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `17.99285% <0.00000%> (-0.00106%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/11472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `47.17008% <0.00000%> (-0.00210%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/11472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `96.98684% <ø> (+0.00087%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/11472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `44.12695% <0.00000%> (-0.02703%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.
LeafShi1 commented 4 months ago

@lonitra Please review this PR.