search

dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.28k stars 955 forks source link

Specify a version of cmake in global.json #11490

Closed directhex closed 2 weeks ago

directhex commented 4 weeks ago

latest is not supported by Arcade, and there's no latest archive in the Azure blob store, so force a supported value here.

CommonLibrary\DownloadAndExtract : Download failed from
  https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/cmake/cmake-latest-win64-x64.zip
  At C:\d\source-indexer\bin\repo\winforms\eng\common\native\install-tool.ps1:90 char:22
Microsoft Reviewers: Open in CodeFlow
ericstj commented 4 weeks ago

Seems that this was changed in https://github.com/dotnet/winforms/pull/7844. @lonitra @JeremyKuhne do either of you know why that might be?

Seems like the only thing that uses CMake here is https://github.com/dotnet/winforms/blob/main/src/System.Windows.Forms/tests/InteropTests/NativeTests/CMakeLists.txt

JeremyKuhne commented 4 weeks ago

Seems that this was changed in #7844. @lonitra @JeremyKuhne do either of you know why that might be?

No idea really, but it is used only for the test project, whatever works here is fine with me.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.40009%. Comparing base (f0811e2) to head (ab1e03d). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11490 +/- ## =================================================== - Coverage 74.40761% 74.40009% -0.00752% =================================================== Files 3030 3030 Lines 628093 628053 -40 Branches 46822 46805 -17 =================================================== - Hits 467349 467272 -77 - Misses 157393 157427 +34 - Partials 3351 3354 +3 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/11490/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/11490/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `74.40009% <ø> (-0.00752%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/11490/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `17.98959% <ø> (-0.01216%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/11490/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `47.22386% <ø> (-0.02372%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/11490/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `96.98788% <ø> (+0.00016%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/11490/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `44.18428% <ø> (-0.04747%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.