search

dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.38k stars 971 forks source link

Cleanup in the ClipboardTests #11491

Closed Tanya-Solyanik closed 3 months ago

Tanya-Solyanik commented 3 months ago

Run Clipboard test sequentially, this is not eliminating potential interferences, but is an improvement in my observations, the next step would be to add a Clear in the try/finally block in every test. enabled nullability in ClipboardTests Used fluent assertions, particularly BeEquivalentTo was helpful to make some tests more specific. Several test names didn't match the content due to a copy/paste mistake

Microsoft Reviewers: Open in CodeFlow
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 95.90643% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.40216%. Comparing base (f0811e2) to head (d41184c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11491 +/- ## =================================================== + Coverage 74.40095% 74.40216% +0.00121% =================================================== Files 3030 3030 Lines 628035 628053 +18 Branches 46803 46805 +2 =================================================== + Hits 467264 467285 +21 + Misses 157418 157411 -7 - Partials 3353 3357 +4 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/11491/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/11491/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `74.40216% <95.90643%> (+0.00121%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/11491/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `17.99029% <ø> (+0.00035%)` | :arrow_up: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/11491/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `47.22842% <ø> (+0.00104%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/11491/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `96.98788% <95.90643%> (+0.00016%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/11491/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `44.21234% <ø> (+0.02700%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.