search

dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.28k stars 955 forks source link

fix issue 11450 Color contrast ratio of focus indicator over 'toolStripSplitButton1' is 1.247:1 which is less than 3:1: A11y_.NET CoreWinforms_StripControls_Toolstripwithmenuitem_NonTextContrast #11502

Open Epica3055 opened 3 weeks ago

Epica3055 commented 3 weeks ago

Fixes #11450

Proposed changes

Screenshots

Before

image

After

image

Test environment(s)

9.0.0-preview.6.24305.2

Microsoft Reviewers: Open in CodeFlow
Tanya-Solyanik commented 3 weeks ago

@Epica3055 - had you investigated if other items have the same issue? Olina's team might be able to help out

Olina-Zhang commented 3 weeks ago

@Tanya-Solyanik @Epica3055 I tested this PR, found an issue: Now the drop-down triangle display for toolStripSplitButton and toolStripDropDownButton looks are same in StatusStrip. But actually in ToolStrip, they are same before.

Before: the drop-down triangle of toolStripSplitButton is bigger than toolStripDropDownButton's. The toolStripSplitButton drop-down triangle size in StatusStrip and ToolStrip keep consistent now image

After: the drop-down triangle size for toolStripSplitButton and toolStripDropDownButton looks are same in StatusStrip. The toolStripSplitButton in StatusStrip and ToolStrip keep consistent now image

Don't know why the toolstripSplitButton's dropdown triangle is displayed differently in StatusStrip.

ricardobossan commented 3 weeks ago

The failing tests have to be addressed.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.39196%. Comparing base (aa61778) to head (53c5b85). Report is 27 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11502 +/- ## =================================================== - Coverage 74.41153% 74.39196% -0.01958% =================================================== Files 3030 3030 Lines 628111 628041 -70 Branches 46824 46808 -16 =================================================== - Hits 467387 467212 -175 - Misses 157376 157484 +108 + Partials 3348 3345 -3 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/11502/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/11502/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `74.39196% <100.00000%> (-0.01958%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/11502/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `17.98251% <ø> (-0.02134%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/11502/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `47.23002% <ø> (-0.02457%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/11502/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `96.96634% <100.00000%> (-0.02155%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/11502/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `44.20535% <ø> (-0.03342%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.