dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.38k stars 971 forks source link

Add WinForms Analyzer and CodeFixes Infrastructure for C# and Visual Basic #11515

Closed KlausLoeffelmann closed 2 months ago

KlausLoeffelmann commented 3 months ago

This PR introduces/extends the WinForms Analyzer infrastructure for C# and Visual Basic. We will be introducing for .NET 9 a first set of Analyzers and Code Fixes, specifically for WinForms applications. The Analyzers will help developers to identify common issues in their WinForms applications and the Code Fixes will help to automatically fix these issues.

The PR includes the following changes:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 97.09677% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.84430%. Comparing base (c3cb9b3) to head (3cf1630). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11515 +/- ## =================================================== + Coverage 74.78710% 74.84430% +0.05720% =================================================== Files 3021 3012 -9 Lines 629289 629269 -20 Branches 46689 46692 +3 =================================================== + Hits 470627 470972 +345 + Misses 155301 154936 -365 Partials 3361 3361 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/11515/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/11515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `74.84430% <97.09677%> (+0.05720%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/11515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `18.03813% <ø> (+0.07912%)` | :arrow_up: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/11515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `47.83718% <94.91525%> (+0.09464%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/11515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `97.02004% <100.00000%> (+0.03443%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/11515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `44.86531% <94.91525%> (+0.00807%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.
KlausLoeffelmann commented 3 months ago

@RussKie: I would very much appreciate if you - in the future - respect my ask to NOT start reviewing a draft PR, especially when I point out that it is not ready for review. I appreciate your valuable engagement, but if I am in the process to completely restructure this, (but still want to see at the end of the day, if pipelines pass), premature reviews generate too much useless noise comments, half of which become redundant, anyway.

UPDATE: No longer Draft.