dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.38k stars 971 forks source link

Make the toolbar menu items support the support space key. #11520

Closed SimonZhao888 closed 2 months ago

SimonZhao888 commented 3 months ago

Fixes #11449

Proposed changes

Customer Impact

Regression?

Risk

-Minimal

Screenshots

Before

BeforeChanges

After

AfterChanges

Test methodology

Test environment(s)

Microsoft Reviewers: Open in CodeFlow
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.56175%. Comparing base (fc56416) to head (d2966bf). Report is 83 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11520 +/- ## =================================================== + Coverage 74.39859% 74.56175% +0.16316% =================================================== Files 3032 3041 +9 Lines 628149 629780 +1631 Branches 46828 46845 +17 =================================================== + Hits 467334 469575 +2241 + Misses 157465 156843 -622 - Partials 3350 3362 +12 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/11520/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/11520/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `74.56175% <65.38462%> (+0.16316%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/11520/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `17.87556% <3.84615%> (-0.12500%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/11520/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `47.45164% <65.38462%> (+0.20467%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/11520/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `96.97796% <ø> (+0.01124%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/11520/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `44.55491% <65.38462%> (+0.32596%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.
ricardobossan commented 3 months ago

All LGTM