dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.28k stars 954 forks source link

Added an opt-in switch to use BinaryFormater.Deserialize in Clipboard get methods. #11526

Closed Tanya-Solyanik closed 2 weeks ago

Tanya-Solyanik commented 2 weeks ago

The switch is not fully used yet. It requires that app opts in into binary formatter use globally.

Microsoft Reviewers: Open in CodeFlow
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 74.40303%. Comparing base (5cefc3d) to head (f1ddf67). Report is 6 commits behind head on feature/clipboard.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/clipboard #11526 +/- ## =========================================================== - Coverage 74.40876% 74.40303% -0.00573% =========================================================== Files 3032 3033 +1 Lines 628254 628211 -43 Branches 46832 46815 -17 =========================================================== - Hits 467476 467408 -68 - Misses 157427 157456 +29 + Partials 3351 3347 -4 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/11526/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/11526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `74.40303% <25.00000%> (-0.00573%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/11526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `17.98008% <0.00000%> (-0.02224%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/11526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `47.24525% <25.00000%> (-0.01672%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/11526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `96.96755% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/11526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `44.19953% <25.00000%> (-0.04420%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.
Tanya-Solyanik commented 2 weeks ago

We'll want to update this to a static helper class that has static Func<TypeName, Type> methods.

Yeah, I updated this branch and then push was incomplete and I didn't notice it. This is why I pinged the thread for a review.