search

dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.28k stars 954 forks source link

Replacing usages of `LocalAppContextSwitches` with `AppContextSwitchScope` #11539

Closed elachlan closed 1 week ago

elachlan commented 2 weeks ago

Working on #11536

Only thing left is LocalAppContextSwitchesTest, but I am unsure how to proceed on that. Since its directly testing LocalAppContextSwitches. https://github.com/dotnet/winforms/blob/79472b41928fe7147527f93651f828088f617c1e/src/System.Windows.Forms.Primitives/tests/UnitTests/System/Windows/Forms/LocalAppContextSwitchesTest.cs#L9-L44

Microsoft Reviewers: Open in CodeFlow
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.45866%. Comparing base (79472b4) to head (6fae8cd). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11539 +/- ## =================================================== + Coverage 74.41004% 74.45866% +0.04861% =================================================== Files 3032 3039 +7 Lines 628262 628902 +640 Branches 46817 46831 +14 =================================================== + Hits 467490 468272 +782 + Misses 157420 157278 -142 Partials 3352 3352 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/11539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/11539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `74.45866% <100.00000%> (+0.04861%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/11539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `17.98839% <ø> (-0.00142%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/11539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `47.30400% <ø> (+0.04785%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/11539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `96.96990% <100.00000%> (+0.00409%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/11539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `44.28701% <ø> (+0.05008%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.