search

dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.38k stars 971 forks source link

[main] Update dependencies from dotnet/runtime #11540

Closed dotnet-maestro[bot] closed 3 months ago

dotnet-maestro[bot] commented 3 months ago

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

lonitra commented 3 months ago

Error:

Unable to find directory for cmake 3.21.0; please make sure the tool is installed on this image.

@directhex we are starting to get some build failures after switching to cmake 3.21.0. It looks like some CI machines do not have that version installed. Any recommendations for what to do here? Should we revert back to latest?

lonitra commented 3 months ago

For now, I have reverted cmake to "latest" to unblock dependency flow, but we should determine best next steps if we should not be using latest

directhex commented 3 months ago

The core problem seems to be two different bits of tooling expecting incompatible things.Revert whatever to keep the build going, but the definitely a bug in the provision behaviour between arcade and not-arcadeSent from my iPhoneOn Jun 17, 2024, at 5:12 PM, Loni Tra @.***> wrote: For now, I have reverted cmake to "latest" to unblock dependency flow, but we should determine best next steps if we should not be using latest

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.41984%. Comparing base (79472b4) to head (26546b2). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11540 +/- ## =================================================== + Coverage 74.41004% 74.41984% +0.00979% =================================================== Files 3032 3032 Lines 628262 628874 +612 Branches 46817 46847 +30 =================================================== + Hits 467490 468007 +517 - Misses 157420 157519 +99 + Partials 3352 3348 -4 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/11540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/11540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `74.41984% <ø> (+0.00979%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/11540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `17.90298% <ø> (-0.08683%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/11540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `47.22458% <ø> (-0.03157%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/11540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `96.96975% <ø> (+0.00395%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/11540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `44.26886% <ø> (+0.03192%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.
kasperk81 commented 3 months ago

@lonitra did you see https://github.com/dotnet/winforms/pull/11542?