dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.28k stars 954 forks source link

Skip test "TextBoxBase_Undo_CanUndo_Success" and "TextBoxBase_Copy_PasteNotEmpty_Success" #11562

Closed LeafShi1 closed 5 days ago

LeafShi1 commented 1 week ago

Related #11559, #11558

Proposed changes

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.40698%. Comparing base (566bec4) to head (f91dff0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11562 +/- ## =================================================== - Coverage 74.48439% 74.40698% -0.07742% =================================================== Files 3039 3039 Lines 629066 629066 Branches 46834 46834 =================================================== - Hits 468556 468069 -487 - Misses 157154 157651 +497 + Partials 3356 3346 -10 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/11562/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/11562/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `74.40698% <ø> (-0.07742%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/11562/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `17.76932% <ø> (-0.20918%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/11562/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `47.18870% <ø> (-0.15962%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/11562/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `96.96194% <ø> (-0.00930%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/11562/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `44.33075% <ø> (-0.00736%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.
paul1956 commented 5 days ago

What is the plan with all the tests that use shared resources like Clipboard? Just skip them, I still believe there is a Xuint solution without putting them all in one file or class but if that’s required by the repo it’s a better solution then skipping them all. Sent from my iPhoneI apologize for any typos Siri might have made.(503) 803-6077On Jun 24, 2024, at 2:03 AM, Leaf Shi @.***> wrote: @LeafShi1 commented on this pull request.

In src/System.Windows.Forms/tests/UnitTests/TextBoxBaseTests.cs:

 [WinFormsFact]

I will do this in next PR

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>