dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.42k stars 986 forks source link

Fix issue 12187 Extra Border Color in DataGridView with RightToLeft. #12210

Closed Epica3055 closed 1 month ago

Epica3055 commented 1 month ago

Fixes #5961

Proposed changes

-

Regression?

Test environment(s)

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.39022%. Comparing base (8d231a0) to head (e3ea34c). Report is 101 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12210 +/- ## =================================================== + Coverage 75.16050% 75.39022% +0.22972% =================================================== Files 3070 3100 +30 Lines 632557 634378 +1821 Branches 46787 46865 +78 =================================================== + Hits 475433 478259 +2826 + Misses 153740 152710 -1030 - Partials 3384 3409 +25 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/12210/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/12210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.39022% <94.11765%> (+0.22972%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/12210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `18.01290% <77.77778%> (+0.04967%)` | :arrow_up: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/12210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `48.76189% <88.88889%> (+0.38049%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/12210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `97.02681% <100.00000%> (+0.00669%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/12210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `45.79758% <88.88889%> (+0.39625%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.
Tanya-Solyanik commented 1 month ago

I agree with Leaf, this should be tested thoroughly. @Syareel-Sukeri - could you please test the PR?

Tanya-Solyanik commented 1 month ago

@Epica3055 This PR changes cell size compared to NET8. Could you please investigate if we can adjust color value here or elsewhere - https://github.com/dotnet/winforms/blob/7c9f958bfd13697dbb1007b6d3bf8c41837790cd/src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridViewCell.cs#L3154