dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.38k stars 971 forks source link

Adds code coverage to Network Download from PR #11863 #12221

Open paul1956 opened 5 days ago

paul1956 commented 5 days ago

Adds VB Netword Download tests

Proposed changes

Customer Impact

Regression?

Risk

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.50453%. Comparing base (0d0e1c9) to head (8bac2f7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12221 +/- ## =================================================== + Coverage 75.42712% 75.50453% +0.07741% =================================================== Files 3102 3105 +3 Lines 634244 635689 +1445 Branches 46866 46868 +2 =================================================== + Hits 478392 479974 +1582 + Misses 152434 152303 -131 + Partials 3418 3412 -6 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/12221/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/12221/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.50453% <100.00000%> (+0.07741%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/12221/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `17.89171% <ø> (-0.08787%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/12221/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `48.85050% <ø> (+0.04680%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/12221/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `97.03960% <100.00000%> (+0.01335%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/12221/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `45.95239% <ø> (+0.11652%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.
paul1956 commented 4 days ago

@Tanya-Solyanik @KlausLoeffelmann this just has network download tests. It's as simple as I can make it.

Please review first

I can then add the other cleanup with no code changes at a later time.