dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.38k stars 971 forks source link

Split Network.VB into 7 Files from PR #11863 #12226

Open paul1956 opened 4 days ago

paul1956 commented 4 days ago

Proposed changes

Customer Impact

Regression?

Risk

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 7.16981% with 492 lines in your changes missing coverage. Please review.

Project coverage is 75.40549%. Comparing base (0d0e1c9) to head (0b2f79a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12226 +/- ## =================================================== - Coverage 75.42712% 75.40549% -0.02164% =================================================== Files 3102 3108 +6 Lines 634244 634418 +174 Branches 46866 46866 =================================================== - Hits 478392 478386 -6 - Misses 152434 152612 +178 - Partials 3418 3420 +2 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/12226/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/12226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.40549% <7.16981%> (-0.02164%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/12226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `17.96714% <0.00000%> (-0.01244%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/12226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `48.77170% <7.16981%> (-0.03200%)` | :arrow_down: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/12226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `97.02624% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/12226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `45.78389% <7.16981%> (-0.05199%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.
paul1956 commented 4 days ago

Reviewer note: coverage is identical to current unmodified code. The tests are in a separate PR #12221 .