Code Coverage for ClipboardProxy from PR #11863

paul1956 commented 1 month ago

Fixes #

Proposed changes

Add Clipboard Proxy Tests from PR #11863

Customer Impact

Improved code quality

Regression?

No

Risk

None add additional tests

Microsoft Reviewers: Open in CodeFlow

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.55655%. Comparing base (f73363f) to head (40b0c61). Report is 5 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #12227 +/- ## =================================================== + Coverage 75.55367% 75.55655% +0.00288% =================================================== Files 3111 3112 +1 Lines 635122 635160 +38 Branches 46914 46919 +5 =================================================== + Hits 479858 479905 +47 + Misses 151803 151794 -9 Partials 3461 3461 ``` | [Flag](https://app.codecov.io/gh/dotnet/winforms/pull/12227/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [Debug](https://app.codecov.io/gh/dotnet/winforms/pull/12227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.55655% <100.00000%> (+0.00288%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/dotnet/winforms/pull/12227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `18.27991% <ø> (-0.01658%)` | :arrow_down: | | [production](https://app.codecov.io/gh/dotnet/winforms/pull/12227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `49.03192% <ø> (+0.00316%)` | :arrow_up: | | [test](https://app.codecov.io/gh/dotnet/winforms/pull/12227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `97.02456% <100.00000%> (+0.00031%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/dotnet/winforms/pull/12227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `45.96665% <ø> (-0.02499%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.

paul1956 commented 1 month ago

@Tanya-Solyanik based on all the work you are doing on Clipboard should I close this? If there are still uncover ClipboardProxy areas I can open a new PR after it's merged.

paul1956 commented 1 month ago

@Tanya-Solyanik The following ClipboardProxy functions are currently missing coverage and the ones I was testing with this PR.

Friend Sub New()
Public Function GetAudioStream() As Stream
Public Function ContainsText(format As TextDataFormat) As Boolean
Public Function GetAudioStream() As Stream
Public Function GetFileDropList() As StringCollection
Public Sub SetAudio(audioBytes As Byte())
Public Sub SetFileDropList(filePaths As StringCollection)

If you have these covered or don't think they need to be I will close.

Tanya-Solyanik commented 1 month ago

If you have these covered or don't think they need to be I will close.

These are covered as exposed from the Clipboard class, we still need tests on the Proxy level that establish that it invokes the CLipboard methods or at least gets the same results as the Clipboard does.

dotnet / winforms