dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.35k stars 965 forks source link

Winforms does not implement windows theme from users profile #2160

Open PeterPann23 opened 4 years ago

PeterPann23 commented 4 years ago

Problem description: Winforms is using standard color scheme and not the users profiles theme

Actual behavior: Color scheme (borders/ colors/ icons) is not the same as in the -net framework nor is it the windows user profile color theme

Expected behavior: One would be able to expect that there would be a option/property to implement legacy or to use the users Profils theme colors. there is no such option, nor does the default color's follow windows 10 color settings.

If executing in windows the forms should be able to pickup the users profile and use the appropriate colors. At the moment a fixed color is used, this is possible to be fixed by overriding on paint but this should not be needed. The usual comment to use WPF is not an option as Winforms is the platform chosen.

It should be relatively easy to have the color scheme be implemented the same way as Application.EnableVisualStyles() is implemented, it even could be a parameter with an enum stating if legacy or windows theme colors should be used. Please note that I'm mentioning colors not WPF rendering.

RussKie commented 4 years ago

It should be relatively easy to have the color scheme be implemented the same way as Application.EnableVisualStyles() is implemented

Could you please describe how you see API change to accommodate your request, and, if you think it would be easy, a draft PR that showcases the requested change. Thanks

PeterPann23 commented 4 years ago

where is a PR template?

RussKie commented 4 years ago

I'm not quite sure what you're asking for. We have a GitHub template that will be shown when you raise a PR, it is here - https://github.com/dotnet/winforms/blob/master/.github/PULL_REQUEST_TEMPLATE.md. As far as the discussion - please post your thought, proposals and designs ideas here.