dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.42k stars 984 forks source link

Brightness contrast of the control boundary line is less than 3:1 #3322

Closed Jessie-Zhang01 closed 1 year ago

Jessie-Zhang01 commented 4 years ago

Related test scenarios:

Minimal repro:

  1. Install the Accessibility Insights from https://accessibilityinsights.io/en/downloads.
  2. Create a winforms core project.
  3. Add a control in the Form designer, build and run this project.
  4. Open the Accessibility Insights and select the Contrast of the directory on the left.
  5. Click on the color picker under Color1 and focus it to the border lines of the control.
  6. Click on the color picker under Color2 and focus it to the background of the control.

Expected behavior: The brightness contrast of the control boundary line should be greater than 3:1.

Actual behavior: Brightness contrast of the control boundary line is less than 3:1. image

wjk commented 4 years ago

I don't think we can do much to change this. These graphics are supplied by uxtheme.dll, which is a part of Windows. The underlying system cannot be changed or extended by anyone outside the Windows team. (That being said, if a High Contrast theme is being used, the bitmaps will change to follow the accessibility tenets of that mode, so there is that.)

merriemcgaw commented 4 years ago

Removing accessibility tags as conversation with @guybark indicates that our controls don't need to meet that boundary requirement because they are rather easy to figure out on their own.

merriemcgaw commented 4 years ago

I didn't know if we wanted to keep this open to evaluate as we look at the theming work we're considering.