search

dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.41k stars 982 forks source link

Remove references to ControlBindingsConverter #3446

Open weltkante opened 4 years ago

weltkante commented 4 years ago

Follow-up to #2412 and #3444

.NET Core Version: github master

Have you experienced this same bug with .NET Framework?: no

Problem description: ControlBindingsConverter is currently defined in the VS designer and no longer present in the WinForms runtime, yet still referenced. The previous approach was to port these by a on-demand basis so this is currently not needed in the WinForms runtime and should be removed to avoid confusion.

Expected behavior: Metadata attributes should not refer to nonexistant classes.

Minimal repro: PR #2230 test failure when removing skip entry

weltkante commented 4 years ago

Some discussion in #3444, @KlausLoeffelmann wants some further internal discussion before removing this, once agreed the removal is trivial.

KlausLoeffelmann commented 4 years ago

Thanks @weltkante!!

@merriemcgaw, @Tanya-Solyanik, @RussKie , @dreddy-work - can we pick this up in the next runtime sync?

merriemcgaw commented 4 years ago

@KlausLoeffelmann - remind me to get it on the agenda, absolutely!