search

dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.35k stars 965 forks source link

Review use of `BC41004` warning #3936

Open RussKie opened 3 years ago

RussKie commented 3 years ago

The latest changes from dotnet/runtime (https://github.com/dotnet/winforms/pull/3804) couldn't be merged due to build failures:

##[error]src\Microsoft.VisualBasic.Forms\src\Microsoft\VisualBasic\Devices\Network.vb(822,20): error BC41004: (NETCORE_ENGINEERING_TELEMETRY=Build) First statement of this 'Sub New' should be an explicit call to 'MyBase.New' or 'MyClass.New' because the 'Public Overloads Sub New()' in the base class 'WebClient' of 'WebClientExtended' is marked obsolete: 'Use HttpClient instead.'

The error was suppressed in https://github.com/dotnet/winforms/pull/3804/commits/590399f903a2bc5a3ac8ef5644e3337b0b0f1179.

The suppression needs to be reviewed, and corrected.

JeremyKuhne commented 1 year ago

@KlausLoeffelmann can you please validate that we don't need to do anything here?

KlausLoeffelmann commented 1 year ago

@KlausLoeffelmann can you please validate that we don't need to do anything here?

Actually, we might need to do something here. I'll talk to @KathleenDollard when I am back in September, to discuss how we tackle this and the fact, that we also have problems still with ensuring Single-Instance in an RDP environment. This might be related, and we may need a different approach altogether.

KlausLoeffelmann commented 1 year ago

This gets mitigated when we finish this https://github.com/dotnet/winforms/issues/9807, which we cannot do in .NET 8.