search

dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.4k stars 976 forks source link

[Accessibility]Color contrast ratio of Collapsed icon of Font node is less than 3:1 #4356

Closed Marie-Shi closed 3 years ago

Marie-Shi commented 3 years ago

More Info:

  1. This issue can also repro on the below scenario: Click Tools->Options-> Text Editor-> C/C++ -> Code Style-> Linter, then click ‘Checkers’ to collapse it, and observe the Color contrast of collapsed icon.
  2. This issue cannot repro on the expand icon of Font node.
  3. There are 2 similar bugs: 1257160, 1236121.

Minimal repro:

  1. Install the Accessibility Insights from https://accessibilityinsights.io/en/downloads.
  2. Extract ‘CollapsedIcon_PropertyGrid_Core.zip’ and open it in VS. CollapsedIcon_PropertyGrid_Core.zip
  3. Build and run this project.
  4. Open the Accessibility Insights and select the Contrast of the directory on the left.
  5. Find the Font node, click on the color picker under Color2 and focus on the background of the collapsed icon.
  6. Click on the color picker under Color1 and focus on the collapsed icon.

Expected behavior: Color contrast ratio of Collapsed icon of Font node should be greater than 3:1.

Actual behavior: Color contrast ratio of Collapsed icon of Font node is 2.411:1, it is less than 3:1. Core_actual

RussKie commented 3 years ago

@merriemcgaw we need guidance on colors taking in considerations WCAG2.1 guidelines.

merriemcgaw commented 3 years ago

This will go on our backlog for the accessibility work. I think we need to just keep this character the same color as the active text. @SergeySmirnov-Akvelon when you guys have the time this should be on our radar.

Amy-Li03 commented 3 years ago

Verified this issue with .NET SDK 7.0.100-alpha.1.21479.26, this issue is fixed. image