search

dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.4k stars 977 forks source link

Row header border line of the DataGridView control has very low luminosity contrast ratio #5961

Open SergeySmirnov-Akvelon opened 3 years ago

SergeySmirnov-Akvelon commented 3 years ago

.NET Core Version:

Have you experienced this same bug with .NET Framework?:

Repro steps:

  1. Create a Form with a DataGridView.
  2. Add multiple columns to a DataGridView.
  3. Add several rows to the DataGridView.
  4. Set DataGridView.RightToLeft = RightToLefYes
  5. Run the application.

Actual behavior: Row header border line of the DataGridView control has very low luminosity contrast ratio.

RightToLeft = Yes: image

RightToLeft = No: image

Expected behavior: Luminosity contrast ratio of the row header border line of the DataGridView control should be greater than 3:1.

elachlan commented 9 months ago

@Olina-Zhang I think this might have been resolved in another issue/pr. Can your team please re-test?

Olina-Zhang commented 9 months ago

It still repro in the latest .Net 9.0 SDK build: 9.0.100-alpha.1.24053.14. image

Olina-Zhang commented 2 months ago

Verified this issue in the latest .NET 9.0 RC1 build: 9.0.100-rc.1.24407.28, it was fixed: image

Olina-Zhang commented 1 month ago

Verified it with .NET 9.0.100-rc.1.24422.10 test pass build that the issue has been fixed, which have the same results as above.

Tanya-Solyanik commented 2 weeks ago

Reverted this fix - https://github.com/dotnet/winforms/pull/12246 due to a regression when GridColor is set to a custom color and incompleteness of this fix - RightToLeft.No layout produces row headers border that it not contrasting enough too. image