dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.4k stars 976 forks source link

A11y_WINFORMS_Winforms-Containers_Winform-Containers_Keyboard:Keyboard focus is going in incorrect direction #7354

Closed Durgajyothi143 closed 2 years ago

Durgajyothi143 commented 2 years ago

.NET version

.NET Framework Version 4.8.04161 Operating System: Windows 11 Enterprise 21H2

Did it work in .NET Framework?

No

Did it work in any of the earlier releases of .NET Core or .NET 5+?

No response

Issue description

GitHubTags:#A11yMAS;#A11yTCS;#.NET Core[WINFORMS]-Win32-June2022;#.NET Core;#A11ySev2;#WCAG2.4.3;#DesktopApp;#Win11;#Benchmark;#Keyboard,#Closed

Actual:

keyboard focus is going in incorrect direction

Expected:

Keyboard focus should go in correct direction

User Impact:

Keyboard users will face difficulties while navigating winform containers tab

Steps to reproduce

  1. Open Core testing solution in VS 2019 Int Preview
  2. Right click on cs.proj file and click on Build. 3.Then run the application. 4.Main Form screen would appear. 5.Navigate to Containers_Controls:Testing the controls under the containers Tab. 6.Winforms_Containers screen would appear.

Attachment: A11y_WINFORMS_Winforms-Containers_Winform-Containers_Keyboard #7354.zip

merriemcgaw commented 2 years ago

@Olina-Zhang can you rearrange the controls so that the last groups with the buttons are in their own column and make sure that TabOrder is correct, left to right then top to bottom.

Once you've gotten that could you check in the fix to the sample project and provide us an EXE to test with here? Thanks so much!

Olina-Zhang commented 2 years ago

Updated TabOrder for tested form, and please using following EXE for testing: AppExE.zip TabOrderUpated

merriemcgaw commented 2 years ago

Assigning to @Durgajyothi143 to validate and close this bug.

Durgajyothi143 commented 2 years ago

@merriemcgaw verified this issue in the latest environment. Issue is not fixed and still able to repro. Could you please provide latest environment with fixes available to verify the issue.

merriemcgaw commented 2 years ago

@Durgajyothi143 - did you use the zip file of the sample app that @Olina-Zhang provided with the latest .NET 7 preview installed? Can you record a gif and show me what the issue is, because it looks above like @Olina-Zhang fixed the issue you mentioned.

Durgajyothi143 commented 2 years ago

Verified the bug in the latest environment Accessibility_Core_7.0_App.zip and still able to repro it. Please find repro attachment for reference. 7354_Repro attachment.zip

merriemcgaw commented 2 years ago

@Olina-Zhang can your team please take a look at the video provided and make sure that we've got the correct focus order in the sample again? It looks like we may have missed something. Thanks!

Olina-Zhang commented 2 years ago

@Durgajyothi143 The app you used is not the updated one, could you please use the above AppExE.zip I attached to test again?

Olina-Zhang commented 2 years ago

Updated TabOrder for tested form, and please using following EXE for testing: AppExE.zip TabOrderUpated

I provided AppExE.zip this time @Durgajyothi143

Durgajyothi143 commented 2 years ago

@Olina-Zhang I have dwonloaded the zip file which u have provided but in this which file i have to open MicrosoftTeams-image (1)

Olina-Zhang commented 2 years ago

@Durgajyothi143 that ExE is an executable file, could you please double-click it to run in file explorer?

Durgajyothi143 commented 2 years ago

@Olina-Zhang When we are trying to run "Accessibility_Core_App.exe" we are getting below error but when we try to install the version mentioned for .NET we are getting version 7.0.0-preview.6.22330.3, so could you please help us to resolve this issue

MicrosoftTeams-image (1)

Olina-Zhang commented 2 years ago

@Durgajyothi143 The issue you met is caused by .Net 7.0 version on your system is lower than that "Accessibility_Core_App.exe" app was built. Please install the higher .Net 7.0 version from: https://github.com/dotnet/installer to test. image

Durgajyothi143 commented 2 years ago

@Olina-Zhang The mention version is not available in the link you have mentioned. Screenshot (50)

merriemcgaw commented 2 years ago

You can find it on this link @Durgajyothi143 https://github.com/dotnet/installer#table

Preview 7 should be out soon but the latest builds are in the table I linked.

Durgajyothi143 commented 2 years ago

Verified the bug as per above comment issue is not reproducing. Hence closing the bug.

A11y_WINFORMS_Winforms-Containers_Winform-Containers_KeyboardKeyboard focus is going in incorrect direction #7354.webm

Tanya-Solyanik commented 1 year ago

Closing per request from @Samhitha66

Issue is fixed. Adding #Closed; tag.