search

dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.35k stars 965 forks source link

listviewitemkeyboardtooltip_invokeishoveredwithmouse_returnsexpected #7428

Open runfoapp[bot] opened 2 years ago

runfoapp[bot] commented 2 years ago
Runfo Tracking Issue: listviewitemkeyboardtooltip_invokeishoveredwithmouse_returnsexpected Build Definition Kind Run Name
Build Result Summary Day Hit Count Week Hit Count Month Hit Count
0 0 0
Tanya-Solyanik commented 2 years ago

Note: this is a theory, maybe only some inputs are flaky?

Olina-Zhang commented 2 years ago

@Tanya-Solyanik this is a tracking issue in runfo, why I don't see this test failure in PR https://github.com/dotnet/winforms/pull/7421's Tests Summary in here: https://dev.azure.com/dnceng/public/_build/results?buildId=1886820&view=ms.vss-test-web.build-test-results-tab? And I checked in here: https://dev.azure.com/dnceng/public/_test/analytics?definitionId=267&contextType=build by this test, there is no failure for it over the past week. In addition, I ran this test in my VM several times, all passed. Do we have to track it again for a while? If it fails almost no times, can we close this bug directly?

RussKie commented 2 years ago

@Olina-Zhang there were several build runs, and one of those failed: image

lonitra commented 1 year ago

It is more difficult to narrow down the cause for this without a callstack, but this test changes the cursor position before doing an assert. https://github.com/dotnet/winforms/blob/9749eb0e0d1b7c992332061133974e0ca6ba6453/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ListViewItem.IKeyboardToolTipTests.cs#L717-L718 We are also changing cursor position for some other tests so running these tests in parallel with each other could be what is causing this flakiness. We should consider running this tests and other tests whose result are dependent on the cursor's position independently

RussKie commented 1 year ago

I venture to suggest this specific test should be in UIIntegration test suite and not in unit test suite.

From: Loni Tra @.> Sent: Thursday, March 2, 2023 10:45 AM To: dotnet/winforms @.> Cc: Igor Velikorossov @.>; Comment @.> Subject: Re: [dotnet/winforms] listviewitemkeyboardtooltip_invokeishoveredwithmouse_returnsexpected (Issue #7428)

It is more difficult to narrow down the cause for this without a callstack, but this test changes the cursor position before doing an assert. https://github.com/dotnet/winforms/blob/9749eb0e0d1b7c992332061133974e0ca6ba6453/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ListViewItem.IKeyboardToolTipTests.cs#L717-L718https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fwinforms%2Fblob%2F9749eb0e0d1b7c992332061133974e0ca6ba6453%2Fsrc%2FSystem.Windows.Forms%2Ftests%2FUnitTests%2FSystem%2FWindows%2FForms%2FListViewItem.IKeyboardToolTipTests.cs%23L717-L718&data=05%7C01%7Cigor.velikorossov%40microsoft.com%7C9c3bc121d51346d7865808db1aaefdf1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638133111122485907%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NxzF6Ip26VaoIw5ITLCUsdGSUKXpyzKp5DDU2Dtxi2Q%3D&reserved=0 We are also changing cursor position for some other tests so running these tests in parallel with each other could be what is causing this flakiness. We should consider running this tests and other tests whose result are dependent on the cursor's position independently

— Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fwinforms%2Fissues%2F7428%23issuecomment-1451038580&data=05%7C01%7Cigor.velikorossov%40microsoft.com%7C9c3bc121d51346d7865808db1aaefdf1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638133111122485907%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=O9msxu%2BuBOIZBzjEmiAC7i6ZRAlUKfITCUHXwYYCTZk%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABBTEXTCQAI7YNHUKCZ43E3WZ7NQJANCNFSM53XBQ2JA&data=05%7C01%7Cigor.velikorossov%40microsoft.com%7C9c3bc121d51346d7865808db1aaefdf1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638133111122485907%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Vuz1m35n%2F1cOYkSkkNi82pZB%2FrB4ZnsRvdCVdbUOfD4%3D&reserved=0. You are receiving this because you commented.Message ID: @.**@.>>