dotnet / winforms

Windows Forms is a .NET UI framework for building Windows desktop applications.
MIT License
4.4k stars 976 forks source link

A11y_.NET Core_WinForms_Print_Microsoft Print to PDF Advanced Options_Keyboard: Keyboard focus is going to text i.e., "Paper size" "Copy count" which is present below "Paper/Output" tree view after press ENTER key the dialog is getting closed. #9252

Closed HindujaArugula closed 1 year ago

HindujaArugula commented 1 year ago

.NET version

.NET-SDK-8.0.100-preview.4.23260.5

Did it work in .NET Framework?

No

Did it work in any of the earlier releases of .NET Core or .NET 5+?

No response

Issue description

GitHubTags:

A11yMAS;#A11yTCS;#BM_.NET Core[Winforms]-Win32-May2023;#.NET Core;#A11ySev2;#WCAG2.1.1#DesktopApp;#Win11;#NonBenchmark;#Keyboard

Actual:

Keyboard focus is going to text i.e., "Paper size" "Copy count" which is present below "Paper/Output" tree view after press ENTER key the dialog is automatically getting closed.

Expected:

Keyboard focus is going to text i.e., "Paper size" "Copy count" which is present below "Paper/Output" tree view after press ENTER key the dialog should not get automatically closed.

User Impact:

Keyboard only users will face difficulties and gets confused if the dialog gets automatically closed after pressing ENTER key.

Attachment:

keyboard focus

Steps to reproduce

  1. Install and Open "Winforms" App.
  2. "Main Form" screen would appear.
  3. TAB to "Printing_Controls:Testing the controls under Printing Tab" and press ENTER key.
  4. TAB to "Print' button and press ENTER key.
  5. Now "Printing from win32 application - Print" appears on the screen.
  6. TAB to "More Settings" button and press ENTER key.
  7. Now "Printing Preference" Screen will appear.
  8. TAB to "Advanced" button and press ENTER key.
  9. Now "Microsoft print to PDF Advanced Options" screen will appear. 10.Now observe that Keyboard focus is going to text i.e., "Paper size" "Copy count" which is present below "Paper/Output" tree view after press ENTER key the dialog is automatically getting closed.
merriemcgaw commented 1 year ago

This is Windows printing common dialogs. This should go under an existing Common Dialogs exception.

12-shweta commented 1 year ago

@merriemcgaw could you please elaborate your comment, could you please help me with some reference using which we can log external bug for this issue. Thanks in advance :)

merriemcgaw commented 1 year ago

@12-shweta - this UI is created using the CommonDialog APIs in Windows. Windows has refused to make changes to multiple legacy UI cases in the CommonDialog APIs. We have an exception already for the OpenFileDialog and the ColorPickerDialog and I've filed another one here for the print and font related dialogs. These are all part of legacy windows UI components that they're moving away from so it doesn't make sense for them to update it. They didn't remove the APIs (nor will we) because that would completely break legacy applications, but customers are advised to use different options.

merriemcgaw commented 1 year ago

@12-shweta and @HindujaArugula - the associated exception has been approved. Can we please close this bug?

HindujaArugula commented 1 year ago

As this is not causing any issue for the user, we are closing this bug.

Closed; #Regressed:08-24-23