search

dotnet / wpf

WPF is a .NET Core UI framework for building Windows desktop applications.
MIT License
7.03k stars 1.17k forks source link

Hyphen based ligatures don't work in WPF #109

Open clairernovotny opened 5 years ago

clairernovotny commented 5 years ago

See https://github.com/tonsky/FiraCode/issues/259 for the full issue description.

Would be good to get this fixed for .NET Core 3.

twelvehouse commented 6 months ago

still broken lol

Vivraan commented 6 months ago

It's a meme at this point Unsubbing and using Jetbrains

masepi commented 5 months ago

Still broken.

Kuldeep-MS commented 5 months ago

Thank you all who pushed for a resolution to this issue. It's your persistent requests which has helped us prioritize it, and I am pleased to announce that we have fixed this and it will be available in .NET9 preview 4.

Brief summary of what has changed: A call to LsTxtFmt (Text Formatter) is made when a line is being created. Previously, in LsTxtFmt, glyphing was only performed for regular characters. However, after the fix, glyphing will also be performed for special characters, such as hyphens.

Here is a sneak peek of how it looks like:

https://github.com/dotnet/wpf/assets/105039373/48ab2e08-93ca-4745-8dd8-fda9ad288694

Please note that this feature is only available for .NET 9(preview4) onwards.

We also want to express heartfelt gratitude to @miloush for helping us with the code reviews and testing.

ThomasGoulet73 commented 5 months ago

@Kuldeep-MS Is it planned to backport it to .Net Framework ?

My guess is no but it would be good to clarify because I've seen Visual Studio mentionned many times in this issue and Visual Studio still runs the .Net Framework version of WPF which means that if this fix is .Net Core only it will not fix Visual Studio.

I'm trying to avoid cases where Visual Studio users might think that this issue being closed would mean that Visual Studio is supposed to be fixed.

Kuldeep-MS commented 5 months ago

@ThomasGoulet73 - We have only made this change available on .NET Core currently. Backporting this to .NET framework is still under discussions with internal teams and at this point of time we cannot commit anything. But in the meantime we wanted collect enough evidences that this feature is not causing any regression.

jogibear9988 commented 5 months ago

Is there a link wich commit fixes this?

Kuldeep-MS commented 5 months ago

@jogibear9988 - The fix has been done in internal repo and since the component is not available publicly, we won't be able to share it here.

jogibear9988 commented 5 months ago

Ah good to know. I thought everything of WPF was opened.

weltkante commented 5 months ago

I thought everything of WPF was opened.

Text processing/rendering is a binary blob (compiled C++ code) thats downloaded during the build and linked into the C++ part of the WPF dll, otherwise I'm sure the community would have offered a fix already (I certainly would have looked into it)

jogibear9988 commented 5 months ago

Is there any reason for this?

pchaurasia14 commented 5 months ago

Is there any reason for this?

@jogibear9988 - Reason for what?

h3xds1nz commented 2 months ago

Is there any reason for this?

@jogibear9988 - Reason for what?

@pchaurasia14 He was asking what's the reason behind the fact that some parts of WPF are not open-sourced. It is true that if one hasn't spent time around here they won't know why since it is not explicitly mentioned for everyone to see.

jogibear9988 commented 2 months ago

did they announce on build they will fix this? https://www.spreaker.com/episode/wpf-update-with-joseph-finney--60662664 time :27:57

pchaurasia14 commented 2 months ago

did they announce on build they will fix this? https://www.spreaker.com/episode/wpf-update-with-joseph-finney--60662664 time :27:57

Yes, this was announced in BUILD 2024.