make MouseDevice mockable

[trivalik]

The class https://github.com/dotnet/wpf/blob/main/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/MouseDevice.cs does not allow right now to derive from it. This prevent any Mocking library to work.

As far as I can see is it enough to change the access modifier from internal abstract MouseButtonState GetButtonStateFromSystem(MouseButton mouseButton);

Code to test with Moq:

var t = typeof(InputManager).GetConstructor(BindingFlags.Instance | BindingFlags.NonPublic, null, new Type[0], null);
var mouseDevice = new Moq.Mock<MouseDevice>((InputManager)t.Invoke(null)).Object;

[miloush]

While I don't think 'mockability' was at any point part of the design and if desired, it should be probably addressed more broadly than picking on a random class, but I do think there is a merit in the claim since the KeyboardDevice does not have the same problem:

  protected abstract KeyStates GetKeyStatesFromSystem( Key key );

If a direct access is required for other classes (i.e. stylus), perhaps protected internal would be a more appropriate choice.

[ghost]

This submission has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 14 days.

It will be closed if no further activity occurs within 7 days of this comment.

[trivalik]

It is not just picking a random class, it is required to fake mouse clicks in unit test. This would lead into a small footprint on run unit test, instead of making a test which execute the whole program and use i.e. FlaUi to do the mouse action. But if this is the way to go, then close the issue.