dotnet / wpf

WPF is a .NET Core UI framework for building Windows desktop applications.
MIT License
7.02k stars 1.16k forks source link

Missing docs blob in ReferenceAssembly.targets #9335

Open NWoodsman opened 2 months ago

NWoodsman commented 2 months ago

Description

I successfully build release/6.0 from the developer console. However when opening the solution, I get some errors.

Intellisense Xml sources not found: IntellisenseXmlDir=\bin\dotnet-api-docs_net6.0\0.0.0.4\_intellisense\net-6.0\

A comment inside ReferenceAssembly.targets states:

  <!-- 
    This blob lives in Azure storage at https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/dotnet-api-docs_net6.0/
    Instructions for updating these artifacts are at https://github.com/dotnet/wpf/blob/master/docs/intellisense.md

Both links appear dead. I would like to follow the instructions and obtain the blob as required.

Reproduction Steps

Visit https://github.com/dotnet/wpf/blob/release/6.0/eng/WpfArcadeSdk/tools/ReferenceAssembly.targets

See line 52 and 53. Links do not work.

Expected behavior

Expected successful resolution of the Azure storage links.

Actual behavior

The specified blob does not exist.

Regression?

No response

Known Workarounds

No response

Impact

Affects builds

Configuration

wpf release/6.0 build.

Other information

No response

NWoodsman commented 2 months ago

I have a second error in wpf\eng\WpfArcadeSdk\tools\ApiCompat.targets line 134

ResolvedImplementationAssembly 'wpf\artifacts\obj\PresentationBuildTasks\Debug\net6.0\PresentationBuildTasks.dll' did not exist.    

In fact, the .dll was built, but it is located at

wpf\artifacts\obj\PresentationBuildTasks\x64\Debug\net6.0\PresentationBuildTasks.dll
lindexi commented 2 months ago

Yeah, the https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/dotnet-api-docs_net6.0 response is:

<Error>
<script/>
<Code>BlobNotFound</Code>
<Message>The specified blob does not exist. RequestId:73fde382-401e-0001-757b-cc3abc000000 Time:2024-07-02T12:30:20.5132521Z</Message>
</Error>
lindexi commented 2 months ago

@NWoodsman I upload the dotnet-api-docs_net6.0.zip here. Could you try download and unzip it to [Repo Root]\.tools\bin\dotnet-api-docs_net6.0\ folder?

NWoodsman commented 2 months ago

Thank you @lindexi

I have copies of all the relevant files. I believe my problem is somewhere in global.json or the build steps as i have copies of the api docs, strawberry-perl, and net4.8 ref assemblies in ~/.netcoreeng as well as in wpf/.tools/bin. It appears my build steps are copying to the .netcoreeng location which is a mismatch due to having newer sdk present on my computer, but I can't figure out.

build.cmd says i'm missing "strawberry-perl": "5.28.1.1-1", "net-framework-48-ref-assemblies": "0.0.0.1", "dotnet-api-docs_net6.0": "0.0.0.4"

in ~/.netcoreeng/

then it says missing in

wpf/.tools/bin

I believe maybe it should not be resolving ~/.netcoreeng

this is release/6.0

NWoodsman commented 1 week ago

@lindexi In \eng\WpfArcadeSdk\tools\ReferenceAssembly.targets, can you help me understand what CommonLibrary_NativeInstallDir resolves to? I'm getting the same error many times from different assemblies.

Intellisense Xml sources not found: IntellisenseXmlDir=\bin\dotnet-api-docs_net6.0\0.0.0.4_intellisense\net-6.0\

Lines 51 - 60 in ReferenceAssembly.targets

  <!-- 
    This blob lives in Azure storage at https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/dotnet-api-docs_net6.0/
    Instructions for updating these artifacts are at https://github.com/dotnet/wpf/blob/master/docs/intellisense.md
  -->
  <IntellisenseXmlDir>$(CommonLibrary_NativeInstallDir)\bin\dotnet-api-docs_net6.0\$(DotNetApiDocsNet60)\_intellisense\net-6.0\</IntellisenseXmlDir>
</PropertyGroup>

<Error Condition="!Exists('$(IntellisenseXmlDir)')"
       Text="Intellisense Xml sources not found: IntellisenseXmlDir=$(IntellisenseXmlDir)" />

I have placed the required \bin\... folder containing the docs in the top level folder, but the error seems to suggest that CommonLibrary_NativeInstallDir does not resolve to the solution root folder.

lindexi commented 1 week ago

I haven't tried that... @NWoodsman