dotnet / xharness

C# command line tool for running tests on Android / iOS / tvOS devices and simulators
MIT License
157 stars 49 forks source link

Invalid Xunit dependency #1170

Closed mattleibow closed 1 day ago

mattleibow commented 6 months ago

Hi folks, I am not sure if I am doing it wrong, but I am trying to use xharness 9.0.0-prerelease.24161.1 and that says it needs xunit.extensibility.execution 2.6.7-pre.5 - which does not exist so it moves up to 2.7.0.

However, this now has a problem since xunit broke api (they added a new default parameter) in 2.7: https://github.com/xunit/xunit/commit/5ef7b75b3e91960aceff9f741ddb4f472fcb625d#diff-54b338f43759528f47a9544e61b807273f8442e7ec4d16a6df237dddf4bce126R43

Now, when I run, my app crashes because of a missing method

not sure why xharness is using a mysterious version - but probably can just use the stable 2.7.0 now?

i have no idea where the $(XUnitVersion) value comes from...

akoeplinger commented 6 months ago

2.6.7-pre.5 exists on dotnet-public so I'm not sure why it's not being found for you: https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-public/NuGet/xunit.extensibility.execution/overview/2.6.7-pre.5

There were more of these breaking API changes (we found them while working on some xunit upgrades hence why we had to push this prerelease version of the package before a fix was was available on nuget.org) but recompiling dependencies "fixed" them.

The $(XUnitVersion) comes from here and you can override it: https://github.com/dotnet/arcade/blob/4e73daf131ef02e8264b0d3e850c4bdafe6e02b6/src/Microsoft.DotNet.Arcade.Sdk/tools/DefaultVersions.props#L86

ivanpovazan commented 1 day ago

@akoeplinger Is there something actionable we can do here, or it is more a note to keep an eye on a potential problem (ie can we close the issue) ?

akoeplinger commented 1 day ago

I don't think there's anything actionable here.