dotnetbio / bio

Bioinformatics library for .NET
Apache License 2.0
145 stars 49 forks source link

Cleanup the MUMmerAligner Class #10

Closed evolvedmicrobe closed 8 years ago

evolvedmicrobe commented 8 years ago

The MUMmer aligner exposed a PairWiseAlgorithm to be used to stitching together of different seeds. There were however a number of constraints that this algorithm must obey but which were not controlled for here. In particular, the algorithm must be a global aligner that returns only one alignment per sequence pair, but this was not enforced. As we only have the NeedleManWunsch aligner that fits the global bill here, I enforced that this class must use this aligner for stitching together seeds. This is a breaking API change, but if anyone was using the old way their code would silently be giving bad results, so it is an appropriate change.

This change also added comments for the aligner.