search

dotnetbio / bio

Bioinformatics library for .NET
Apache License 2.0
144 stars 49 forks source link

FASTA parser doesn't support comments #17

Open flipchart opened 8 years ago

flipchart commented 8 years ago

I realize comments aren't documented (and thus probably not supported by) the NCBI docs linked in the parser file, but I feel this is something simple to support and makes the parser a little less strict as comments are simply ignored. Happy to send a PR for the feature if it's something you're interested in

evolvedmicrobe commented 8 years ago

Do you mean comment lines that start with a ";"? I have never seen FASTA files like that before, but if you wanted to submit a PR I can't think why it wouldn't be accepted as a feature (probably makes the most sense to store any comments in the metadata object).

jamesmhogan commented 8 years ago

Usually in the header, but I can't see any reason not to support it either.

evolvedmicrobe commented 8 years ago

Always happy to see features extended!