Closed dplarina closed 4 months ago
Hello, there are some problems when running unit tests. Please adjust them. Thank you for your PR.
Sorry. I can't even find the relevant test to begin to know how to troubleshoot that.
Also the failure appears be happening in code unrelated to the code change. I assume this test is ensuring that multiple threads can access the cached value (cache hits), while the code change is related to cache misses.
All CI check have passed. @Memoyu
Fixes #523
If the implementation's dataRetriever() throws an exception, the relevant cache key stays locked and will never recover. This removes the lock if there is an exception.
Also when the disk cache provider is initialized, added ignoring existing _Lock keys for situations where the app crashed or was restarted while the Lock was saved to the keys.dat.