search

dotnetprojects / SVGImage

A SVGImage Control for WPF
http://dotnetprojects.github.io/SVGImage/
MIT License
199 stars 41 forks source link

Added new eSizeType.ViewBoxToSizeNoStretch #71

Closed TSerious closed 1 year ago

TSerious commented 1 year ago

The current SizeTypes do not support to take the viewbox into account. With this change not the content but the viewbox (if there is one) could be used to calculate the scale.

paulushub commented 1 year ago

Maintain the defaults to avoid breaking current codes.

TSerious commented 1 year ago

I've now restored the defaults. Sorry for my mistake, I didn't wanted to push this commit.

paulushub commented 1 year ago

@jogibear9988 Any remaining issue?

jogibear9988 commented 1 year ago

If I look in the last commit, still the default of the property is changed, I think we should keep the old default

jogibear9988 commented 1 year ago

old was ContentToSizeNoStretch new is ContentToSizeStretch

jogibear9988 commented 1 year ago

will you fix this?

paulushub commented 1 year ago

@jogibear9988 OK! will fix the current build error and restore the default for the eSizeType. Any problem, if I remove the obsolete NetCoreApp3.0? (NetCoreApp3.1 is already supported)

jogibear9988 commented 1 year ago

i don't need 3.0 and also don't need 3.1

jogibear9988 commented 1 year ago

thx

paulushub commented 1 year ago

i don't need 3.0 and also don't need 3.1

The 3.1 could be breaking for many, as it is the base for those using .NET 5-8. I will add support for for .NET 6~7, since .NET 5 is already obsolete, which means moving the projects to VS 2022. Then, next we can take down the Core 3.1.