search

dotnetthailand / dotnetthailand.github.io

source code for .NET Thailand website (dotnetthailand.com)
https://www.dotnetthailand.com
MIT License
61 stars 100 forks source link

Remove warning `warn the option sizeByPixelDensity is deprecated and should not be used. It will be removed in the next major release of Gatsby.` #207

Open kaiwanyawit-chawankul opened 2 years ago

kaiwanyawit-chawankul commented 2 years ago

warn the option sizeByPixelDensity is deprecated and should not be used. It will be removed in the next major release of Gatsby.

image

Should we change this deprecated function?

CC: @aaronamm @mildronize

mildronize commented 2 years ago

@kaiwanyawit-chawankul Thanks for your suggestion, my opinion it doesn't hurry to fix this issue, because in order to migrate Gatsby with major release is not easy, due to a huge dependency of this project. this project still use Gatsby 2.x,

Answer your question, if we can migrate from Gatsby 2.x to 3.x, this deprecated function will be more easy.

aaronamm commented 2 years ago

@kaiwanyawit-chawankul Thanks for your suggestion and agree with @mildronize for his idea. I think we should consider to migrate our website to Gatsby version 4 as our first priority.

However, I don't know if you would like to help us on migration. Please let me know if you would like to try or not. I am happy to support you but I accept this might be a huge PR, LoL.

kaiwanyawit-chawankul commented 2 years ago

Hi @mildronize @aaronamm,

This error came from gatsby-plugin-sharp for warning about sizeByPixelDensity which is have nothing to do with the use in gatsby-remark-images

image

That mean we don't have to worry about it. Based on those links below. Maybe I am wrong.

https://diff.intrinsic.com/gatsby-plugin-sharp/2.0.36/2.0.37 https://github.com/gatsbyjs/gatsby/issues/23376 https://github.com/gatsbyjs/gatsby/issues/12743

What do you think?

mildronize commented 2 years ago

I think @kaiwanyawit-chawankul you can be true, could you please remove that line?