Audio filters/effects

[dotnize]

Command to set audio filters eg:

-filter <options>
options: off, bassboost, nightcore, vaporwave, etc

• [x] basic filters such as bassboost, nightcore, vaporwave, phaser, etc
• [x] support for multiple filters enabled at once
• [x] add more common filters (and possibly custom ones)

https://discord-player.js.org/docs/main/master/typedef/AudioFilters https://discord-player.js.org/docs/main/master/class/Queue?scrollTo=setFilters

[JoshCunningHum]

I finished adding the filter feature. However, it is still lacking some things (for error handling) like:

• Returns if there is no music playing
• Returns if 'filter off' is called even though there is no filter running
• Returns if the filter is already running but called again

and I can't find a way to pass an "off" filter, this is what I did but all caused crash

    Passing emtpy object
    queue.setFilters({}) // crashes the bot

    Passing a filter then turning it off
    queue.setFilters({"3D" : true});
    queue.setFilters({"3D" : false}); // crashes the bot

    Just callling the function
    queue.setFilters(); // crashes the bot

so what I did is this

  queue.setFilters({"normalize" : true});

Anyways, how do I create a pull request? :sweat_smile:

EDIT:

Found a way to pass an "off" without crashing and setting normalizer as true

[dotnize]

Anyways, how do I create a pull request? 😅

https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

I actually sent you an invite yesterday so you can directly make changes in the repository without having to make a fork/PR. Should probably be in your email :]

[JoshCunningHum]

:laughing: My bad I don't usually check my Gmail, but before I pull,

Should the bot override the current filter/s when passing filters?

-filter vaporwave phaser     // adds the vaporwave and phaser filters

-filter nightcore    // Disables the vaporwave and phaser filters and enables nightcore

or

Should the bot just add the filter/s when passing filter/s without disabling the filter/s that is/are already enabled?

-filter vaporwave // adds the vaporwave filter

-filter nightcore // adds the nightcore filter without disabling the vaporwave filter

The latter might be a hassle when replacing the current filter, they need to turn all filters off first then apply the filter but it's your choice, just give me a word

Going to eat, for now. I'll check this later

Thanks btw for inviting me

[dotnize]

Should the bot override the current filter/s when passing filters?

-filter vaporwave phaser     // adds the vaporwave and phaser filters

-filter nightcore    // Disables the vaporwave and phaser filters and enables nightcore

Yup. This should be the easier choice for users.

Thanks for the contribution!