search

dotpcap / packetnet

Official repository - High performance .Net assembly for dissecting and constructing network packets such as ethernet, ip, tcp, udp etc.
Mozilla Public License 2.0
469 stars 105 forks source link

sharppcap Windows tests fail #150

Closed PhyxionNL closed 2 years ago

PhyxionNL commented 2 years ago

@chmorgan Maybe you can look into this. I'm not using pcap stuff that much, but it works here locally. I'm also wondering whether it needs updating to npcap as winpcap isn't supported anymore.

kayoub5 commented 2 years ago

winpcap still supported, some tests are disabled in CI if dependent on minimum libpcap version, what tests fail for you?

PhyxionNL commented 2 years ago

winpcap still supported,

On their site: WinPcap Has Ceased Development. We recommend Npcap.

some tests are disabled in CI if dependent on minimum libpcap version, what tests fail for you?

All fail due to wcap DLL failure, see: https://github.com/chmorgan/packetnet/runs/3777064424?check_suite_focus=true

kayoub5 commented 2 years ago

github actions Windows virtual environment is not compatible with winpcap or npcap, this is a CI limitation not a library limitation.

PhyxionNL commented 2 years ago

github actions Windows virtual environment is not compatible with winpcap or npcap, this is a CI limitation not a library limitation.

Well, it used to work and weirdly, sometimes it still does: https://github.com/chmorgan/packetnet/runs/3777070826

kayoub5 commented 2 years ago

could be that winpcap install silently failed. wpcap not found means no winpcap was found in the system. @chmorgan have an oem key for npcap, you may want to try try using that.

chmorgan commented 2 years ago

Yeah I can look at pulling that installer script abs secret key over. Inconsistent CI runs are such a time sink, if npcap resolves that would be great.

On Sun, Oct 3, 2021 at 5:09 AM Ayoub Kaanich @.***> wrote:

could be that winpcap install silently failed. wpcap not found means no winpcap was found in the system. @chmorgan https://github.com/chmorgan have an oem key for npcap, you may want to try try using that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chmorgan/packetnet/issues/150#issuecomment-932893927, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJH4AHNPXJXP4WNFGL7POTUFAMTJANCNFSM5FGQEKQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

alexhiggins732 commented 2 years ago

Is this still open? https://github.com/dotpcap/packetnet/actions shows the last 4 build succeeded.

PhyxionNL commented 2 years ago

Seems to work again, closing.