dotpcap / packetnet

Official repository - High performance .Net assembly for dissecting and constructing network packets such as ethernet, ip, tcp, udp etc.
Mozilla Public License 2.0
476 stars 105 forks source link

LinkLayers have wrong base type #167

Closed kayoub5 closed 2 years ago

kayoub5 commented 2 years ago

Currently the LinkLayers assumes that it is a single byte, and that max value is 255.

This is not right:

Danger

Changing the base type of this field is a breaking change, that will affect backward compatibility with all dependencies, including but not limited to sharppcap.

PhyxionNL commented 2 years ago

Let's follow IETF here and make it to 16 bit. Might be useful to update the link types then as well based on tcpdump / https://datatracker.ietf.org/doc/html/draft-ietf-opsawg-pcap#section-8.2