log4net dependency in nuget package

dotpcap / packetnet

Official repository - High performance .Net assembly for dissecting and constructing network packets such as ethernet, ip, tcp, udp etc.

Mozilla Public License 2.0

482 stars 104 forks source link

log4net dependency in nuget package #181

Closed wo80 closed 2 years ago

wo80 commented 2 years ago

Hi. The latest nuget packages (1.4.5, 1.4.6-pre) have a dependency on log4net. Is this intended? Looking at the PacketDotNet.csproj project file, it seems a debug version was published by accident...

PhyxionNL commented 2 years ago

I see, that's odd. It should build the release version: https://github.com/dotpcap/packetnet/blob/master/.github/workflows/master.yml#L70

I've pushed a commit that hopefully addresses it :)

PhyxionNL commented 2 years ago

It was because dotnet test was building the debug version, which caused a debug NuGet package to be generated as well. This'll be fixed in #183.

wo80 commented 2 years ago

Thanks for the quick 1.4.6 release!