dotpcap / sharppcap

Official repository - Fully managed, cross platform (Windows, Mac, Linux) .NET library for capturing packets
1.33k stars 268 forks source link

Use Codecov uploader where possible #388

Closed kayoub5 closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #388 (8bc517d) into master (d85b76c) will increase coverage by 0.26%. The diff coverage is n/a.

:exclamation: Current head 8bc517d differs from pull request most recent head 8dca963. Consider uploading reports for the commit 8dca963 to get more accurate results

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
+ Coverage   83.22%   83.49%   +0.26%     
==========================================
  Files          49       49              
  Lines        2748     2799      +51     
  Branches      301      316      +15     
==========================================
+ Hits         2287     2337      +50     
+ Misses        347      346       -1     
- Partials      114      116       +2     
Flag Coverage Δ
linux ?
macos ?
windows_2019_npcap ?
windows_2019_winpcap ?
windows_2022_npcap ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
SharpPcap/LibPcap/PcapDevice.cs 76.26% <0.00%> (-0.51%) :arrow_down:
SharpPcap/LibPcap/SendQueue.cs 82.44% <0.00%> (+2.15%) :arrow_up:
SharpPcap/ARP.cs 93.40% <0.00%> (+2.19%) :arrow_up:
SharpPcap/Pcap.cs 91.17% <0.00%> (+11.76%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d85b76c...8dca963. Read the comment docs.

kayoub5 commented 2 years ago

@chmorgan review

kayoub5 commented 2 years ago

@chmorgan Code Review?

kayoub5 commented 2 years ago

This looks ok but I don’t follow what this was fixing in terms of the ci build or if it’s a cleanup. Maybe @PhyxionNL would be a better reviewer?

Codecov Bash Uploader got deprecated, so switching to the new system See https://about.codecov.io/blog/codecov-uploader-deprecation-plan/