search

dotpcap / sharppcap

Official repository - Fully managed, cross platform (Windows, Mac, Linux) .NET library for capturing packets
1.28k stars 267 forks source link

Change license to MIT #494

Closed kayoub5 closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f7022f0) 82.64% compared to head (9573375) 82.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #494 +/- ## ========================================== + Coverage 82.64% 82.71% +0.07% ========================================== Files 51 51 Lines 2823 2823 Branches 312 312 ========================================== + Hits 2333 2335 +2 + Misses 366 365 -1 + Partials 124 123 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kayoub5 commented 6 months ago

@chmorgan could you review this? the coverage change seems to be sporadic due to https://github.com/dotpcap/sharppcap/blob/master/SharpPcap/WinDivert/WinDivertDevice.cs#L140-L154 block having the lines covered change depending on packet count/buffer size.

chmorgan commented 6 months ago

@kayoub5 oh and no idea on the coverage issue. Surprised we'd get different results on different runs but maybe we have some tests that use random data without using a fixed random number seed.

kayoub5 commented 6 months ago

Overview of this looks good to me. Did you generate this by hand or some application that went through git history to update it?

For license I used a reuse-tool to inject the MIT header. For copyright I checked files history manually, then used reuse-tool to make sure no file is missing copyright header (even added CI job for it), I didn't double check files that already had a copyright header.