search

dotps1 / HPWarranty

PowerShell module to help retrieve Hewlett-Packard Warranty Information
https://www.powershellgallery.com/packages/HPWarranty/
43 stars 17 forks source link

HPEntWarranty not returning active Carepack Entitlement #33

Open plantronic opened 7 years ago

plantronic commented 7 years ago

Get-HPEntWarrantyEntitlement only returns hardware entitlement, not carepack entitlement. This command only returns a single value for entitlement start/end, whereas Get-HPIncWarrantyEntitlement returns an array in case of additional carepack entitlement.

Web-warranty-check on HP's website for enterprise devices returns correct entitlement info for all devices I've tried it on so far.

jbruettcva commented 7 years ago

Confirmed with one of my servers. Dates returned are for base warranty, not including additional carepacks

dotps1 commented 7 years ago

I'm going to dig into this this weekend

jbruettcva commented 7 years ago

Shot you a copy of the XML output from the process with a care pack listed. If you look at the contract section of the xml, there is a property HeaderEndDate that coincides with the end date of the care pack. Would need to test against a server with no care pack and one with multiple care packs, neither of which exist in my environment that I'm aware of.

plantronic commented 7 years ago

any news on this as of yet? I had a quick look around around the code. The only significant difference I can see is the way the "$output" hastable is generated between "Inc" and "Ent" requests. Although I'm not really familiar with the responses from HP for Inc and Ent requests that might be responsible for different handling.

MartinHenriksson commented 7 years ago

I am still getting the problem with this. I have started looking at changing the results to get the carepack, but I would like to know if you had any success dotps1 as its your baby after all.

rathmel commented 7 years ago

MartinHenrikson - I have fixed this error, if you want to try it.. I don't know if this is against the rules or not, so sorry if it is.. Let me know if you want it.. Rath

dotps1 commented 7 years ago

You should open a Pull Request @rathmel and ill merge it.

rathmel commented 7 years ago

Walking out the door for the day, but I will totally do this for you tomorrow! Have a great evening! Rath

From: Thomas Malkewitz [mailto:notifications@github.com] Sent: Thursday, April 27, 2017 2:13 PM To: dotps1/HPWarranty HPWarranty@noreply.github.com Cc: Adkins II, Glen Glen.Adkins@osumc.edu; Mention mention@noreply.github.com Subject: Re: [dotps1/HPWarranty] HPEntWarranty not returning active Carepack Entitlement (#33)

You should open a Pull Request @rathmelhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rathmel&d=DwMCaQ&c=k9MF1d71ITtkuJx-PdWme51dKbmfPEvxwt8SFEkBfs4&r=Jqio3Q6PN71dl_AHOvjcfQ_5KvIAZAs06dtW1DKlDEg&m=M8z_N5sfdN6E0D8zjiSWrrefm9yx5bexBZdi7J8OkNI&s=yk7NWV7YlKnJvtPht6ew1B5-DR01fdJpvZi9F892upA&e= and ill merge it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_dotps1_HPWarranty_issues_33-23issuecomment-2D297795442&d=DwMCaQ&c=k9MF1d71ITtkuJx-PdWme51dKbmfPEvxwt8SFEkBfs4&r=Jqio3Q6PN71dl_AHOvjcfQ_5KvIAZAs06dtW1DKlDEg&m=M8z_N5sfdN6E0D8zjiSWrrefm9yx5bexBZdi7J8OkNI&s=BtoVTqRqiDJrHZIp5hl7H9Z2Elh7GmakrXpy0m77vOs&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_Aaz0v1EitkOQCr-5Fnx6Qnf-5F-2Dj6BMz1TRSks5r0NqzgaJpZM4KupNR&d=DwMCaQ&c=k9MF1d71ITtkuJx-PdWme51dKbmfPEvxwt8SFEkBfs4&r=Jqio3Q6PN71dl_AHOvjcfQ_5KvIAZAs06dtW1DKlDEg&m=M8z_N5sfdN6E0D8zjiSWrrefm9yx5bexBZdi7J8OkNI&s=n6dWF-lPZMg78BeI9mV7egnbwiv8NzZy35TPKi3p0iM&e=.

rathmel commented 7 years ago

I THINK I have opened the pull request correctly. I have never done it before. HA! All you would need to do is drop my edited file into your PS module directory, and it should work. Let me know. Rath

From: Thomas Malkewitz [mailto:notifications@github.com] Sent: Thursday, April 27, 2017 2:13 PM To: dotps1/HPWarranty HPWarranty@noreply.github.com Cc: Adkins II, Glen Glen.Adkins@osumc.edu; Mention mention@noreply.github.com Subject: Re: [dotps1/HPWarranty] HPEntWarranty not returning active Carepack Entitlement (#33)

You should open a Pull Request @rathmelhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rathmel&d=DwMCaQ&c=k9MF1d71ITtkuJx-PdWme51dKbmfPEvxwt8SFEkBfs4&r=Jqio3Q6PN71dl_AHOvjcfQ_5KvIAZAs06dtW1DKlDEg&m=M8z_N5sfdN6E0D8zjiSWrrefm9yx5bexBZdi7J8OkNI&s=yk7NWV7YlKnJvtPht6ew1B5-DR01fdJpvZi9F892upA&e= and ill merge it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_dotps1_HPWarranty_issues_33-23issuecomment-2D297795442&d=DwMCaQ&c=k9MF1d71ITtkuJx-PdWme51dKbmfPEvxwt8SFEkBfs4&r=Jqio3Q6PN71dl_AHOvjcfQ_5KvIAZAs06dtW1DKlDEg&m=M8z_N5sfdN6E0D8zjiSWrrefm9yx5bexBZdi7J8OkNI&s=BtoVTqRqiDJrHZIp5hl7H9Z2Elh7GmakrXpy0m77vOs&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_Aaz0v1EitkOQCr-5Fnx6Qnf-5F-2Dj6BMz1TRSks5r0NqzgaJpZM4KupNR&d=DwMCaQ&c=k9MF1d71ITtkuJx-PdWme51dKbmfPEvxwt8SFEkBfs4&r=Jqio3Q6PN71dl_AHOvjcfQ_5KvIAZAs06dtW1DKlDEg&m=M8z_N5sfdN6E0D8zjiSWrrefm9yx5bexBZdi7J8OkNI&s=n6dWF-lPZMg78BeI9mV7egnbwiv8NzZy35TPKi3p0iM&e=.

MartinHenriksson commented 7 years ago

@rathmel Fantastic work! I had not been able to do this. I'm still a work in progress as far as Powershell goes sometimes. This works as a charm on my side.