search

dotsam / homebridge-milight

MiLight/LimitlessLED/Easybulb Plugin for Homebridge
MIT License
63 stars 12 forks source link

Wrong Saturation/Brightness/Colour #24

Closed DasPflanze closed 7 years ago

DasPflanze commented 7 years ago

In my setup (1 RasPi, 1 iBox2, 2 RGB Controller, 2 IKEA Dioder) everything works fine, but the staturation is wrong. Also setting the colourwheel to white, changes the LED to red. Setting it slightly beside the center activates the white mode, but the brightness is set too low. So i have to increase the brightness manually to get the full white mode.

pjimage

pjimage 1

mwittig commented 7 years ago

@dotsam @DasPflanze I think the problem is a glitch in the Milight full color model. Different to what you may expect from HSV and HSL color models a saturation value of 100 does not mean 100% saturation, but it is 0% saturation. In other words the saturation value is inverted. I'll look into this asap as part of the underlying lib node-milight-promise to add an option for automatically inverting the saturation value. It should also be possible to fix it right away as part of homebridge-milight, however.

DasPflanze commented 7 years ago

Ok, it sounds logical. Thank you very much!

dotsam commented 7 years ago

I've implemented this in the dev branch, if you want to install that and see how it works. Thanks!

dotsam commented 7 years ago

This has been confirmed to be fixed by testers in #19, so I'll be pushing a new version to npm shortly.