search

dotscad / trains

Toy train Things
29 stars 8 forks source link

request: double side track #1

Closed MoonshineSG closed 4 years ago

MoonshineSG commented 8 years ago

would it be possible to modify the lib to add wheel rails on both sides, above and under, of the tracks ?

ex-nerd commented 8 years ago

I don't have any current plans to add any pre-made shapes for track with wheel wells on top/bottom but there's nothing stopping someone from using tracklib to do so. Just have to rotate things and apply difference() where appropriate. Some of the points ("splitters/junctions") might end up having too large of bridge prints, though, so I'd recommend only using it for the single-track parts.

That said, I wouldn't be averse to a patch.

MoonshineSG commented 8 years ago

so far I managed to modify "wood_rails_2d" to add the bottom rail, but adding the bevel is a bit tricky...

EDIT: but not impossible. i forked your repo and added double side (not sure if it's the best way to do it, but works ... ) :D

u0nel commented 4 years ago

@MoonshineSG did you pull request it? Because I think it should be in the official repo too. And it seems to work in your fork so then why is this issue still open?

MoonshineSG commented 4 years ago

because it's been 4 years and since then my son stoped playing with trains and I kinda forgot about it :D.... feel free to close it... or wait.. i'll do it..

u0nel commented 4 years ago

But why is it not in this repository? Why didn't you make a pull request?