rancid-cvs should test for potential `git init` failure

[jeremyvisser]

When initialising my repository, I got the following:

rancid@intranet:~$ /usr/lib/rancid/bin/rancid-cvs 
Initialized empty Git repository in /var/lib/rancid/.git/

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for <rancid@intranet.contoso.com>) not allowed

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for <rancid@intranet.contoso.com>) not allowed

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for <rancid@intranet.contoso.com>) not allowed

The root cause may be problems within /etc/passwd — I notice the Debian package did not assign a 'full name' to the rancid user, meaning git could not successfully guess a name.

I suggest to either:

• refuse to proceed with git init and friends if user.name and user.email are not set, or perhaps even better:
• automatically set user.name to RANCID and user.email to rancid@$(hostname -f) (Side note: I'm not sure if hostname -f is reliable on all machines. Maybe it would be safer to use rancid@localhost instead?)

In addition to the above, it would be good to have the Debian package assign a full name to the rancid user.

[dotwaffle]

I've added a GECOS field to the adduser -- are you able to test this for me? I'm not in a position to test with a live debian system at the moment.

[jeremyvisser]

Will test and report back when I have a chance.

[jeremyvisser]

I can confirm that adding that GECOS field made it happy enough to proceed on first go.

[dotwaffle]

Marvellous -- thanks for the bug reports ;)