search

dotwaffle / rancid-git

DEPRECATED -- Strongly consider using the upstream, the version here is very out of date and a poor place to start from!
http://www.shrubbery.net/rancid/
Other
218 stars 92 forks source link

RPM spec file references old SHA #22

Closed samdoran closed 10 years ago

samdoran commented 10 years ago

The %{commit} variable in rancid-git.spec references SHA 788157a, which is from May 2013. I'm not sure if this is intentional, e.g., this is the latest "stable" release. If not, it would be nice if this variable could be updated to a newer commit.

I was able to successfully build an RPM from the latest commit (as of this writing) by changing this variable to 6b843b4f74fac89296b9fb325efa5eac1971b284 and exporting an archive.

git archive -o rancid-git-2.3.8-6b843b4.tar.gz --prefix=rancid-git-6b843b4f74fac89296b9fb325efa5eac1971b284 6b843b4
dotwaffle commented 10 years ago

I'll be honest here, I have no idea what I'm doing when it comes to RPM packaging.

Do you know of a macro or similar I could set that would automatically choose the commit you currently have checked out?

I notice there's also some legacy stuff there that probably needs clearing up (the ISEexchange reference etc) -- perhaps I need to dedicate some time to it!

samdoran commented 10 years ago

It looks like Paul Morgan used tito on commit 1112b77780 to update the spec file. That looks like a very robust way to keep the spec file updated as well as generate tar.gz files or rpms.

dotwaffle commented 10 years ago

The latest commit should grab the latest "master" push from my repo. I try to only ever push stuff that builds -- I've had to slightly break that rule as I don't have a Redhat system to test it on!

Hope that helps!