search

dotwaffle / rancid-git

DEPRECATED -- Strongly consider using the upstream, the version here is very out of date and a poor place to start from!
http://www.shrubbery.net/rancid/
Other
218 stars 92 forks source link

From upstream rancid (version 3.2): improved ip address sorting. #69

Closed ryanchapman closed 8 years ago

ryanchapman commented 8 years ago

Without this patch, the items below do not sort correctly. The output from IOS "show ip interface" and "show ipv6 interface" is unsorted and doesn't come back in any deterministic order, so every invocation of rancid leads to the "IPv4 Address:" and "IPv6 Address:" sections being updated in git and emails sent to admins.

1) CIDR notation. For example, "!IPv4 Address: 172.30.2.2/28 on Vlan2502" On Cisco IOS, CIDR is output when the commands "show ip interface" and "show ipv6 interface" are executed.

2) IPv6 addresses. For example, "!IPv6 Address: FD80:EEEE:AC:1E18::1/64 on Vlan3024" On Cisco IOS, IPv6 CIDR is output when the command "show ipv6 interface" is executed.

ryanchapman commented 8 years ago

This comes from the official source release of rancid 3.2 ftp://ftp.shrubbery.net/pub/rancid/rancid-3.2.tar.gz

I should add that according to http://www.shrubbery.net/rancid/CHANGES, this was originally added by Nick Hilliard:

rancid.pm: rework IP address sorting based on patch from Nick Hilliard http://www.shrubbery.net/pipermail/rancid-discuss/2015-February/008030.html

The message boards suggest Robert Drake may have contributed as well: http://www.shrubbery.net/pipermail/rancid-discuss/2015-June/008465.html

Hard to tell who exactly was the author of everything because rancid upstream doesn't appear to have a public versioning system.

ryanchapman commented 8 years ago

Any interest in this or should I close?

dotwaffle commented 8 years ago

Ryan, definitely interested, I'm just not at home at the moment -- I've been at RIPE, followed by Hong Kong, followed by Singapore.

I'll get back to the UK next week and be able to test it. Sorry for the delay!

ryanchapman commented 8 years ago

No worries, just wanted to make sure there was interest. I'll wait a few weeks for you to get back and have some time to work on it.

Ryan